feat(fe): add warning for 'x==y;' statement #1219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what to do regarding the failing docs check on E0343 and E0342, is there any way to declare that the new E0459 should also be triggered here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1132
Add a new diagnostic E0459 that warns on statements that are expressions and the first operator is either
==,===,!=or!==.While adding this I had to change several tests (especially ones relating to redundant string case checks) from
test_parse_and_visit_statementtotest_parse_and_visit_expression, as they were causing false positives. The changes should not affect the tests in any way.Also, I was thinking that maybe this could be widened (or a second diagnostic could be introduced) for statements that are completely redundant (e.g.
x+y;)? If this is implemented expressions that can have side effects likex(),x.a()orx() ? y : zwill have to be checked for, as warning on these could advise removal that would incorrectly affect program flow. I would think false positives could also be quite likely.